Skip to content

Birmingham | 26-ITP-Jan | Merve Reis | Sprint 1 | Wireframe #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mervereis wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Birmingham | 26-ITP-Jan | Merve Reis | Sprint 1 | Wireframe #1118

mervereis wants to merge 3 commits into from
+104 −38

Conversation

@mervereis
Copy link

@mervereis mervereis commented Feb 2, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I transformed wireframe to an html page.

@netlify
Copy link

netlify bot commented Feb 2, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 4d4daaf
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/698524ed0a5c6d00082462ad
😎 Deploy Preview https://deploy-preview-1118--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@mervereis mervereis added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Feb 2, 2026
cjyuan
cjyuan reviewed Feb 5, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is free of syntax errors and well indented. Well done!

1

When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you
- Align the height of the image in articles 2 and 3? (In the wireframe they have the same height)

2

The footer content is not quite centered. Can you make it "more center"?

Image

Note: The gap between articles 2 and 3 should be on the center of the page.

Optional change

The spacing in the second article appears to be slightly different from that in the third. In particulars,

  • The vertical gap before and after the article title
  • The margin/padding size around the "Read More" link
    With the original CSS, this spacing issues appears to be affected by the content length. Can you modify the CSS code to make the spacing more consistent in all articles regardless of content length?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 5, 2026
@mervereis
Copy link
Author

mervereis commented Feb 5, 2026

@cjyuan I made the changes thank you for feedback.

@cjyuan
Copy link
Contributor

cjyuan commented Feb 5, 2026

I don't see any new commits on this branch. Did you forget to push the changes to GitHub, or have you made the changes you on a different branch?

Please note in ITP, when your PR is ready to be re-reviewed, you should also add a "Needs review" label to the PR in addition to responding to reviewer's feedback.

@mervereis mervereis added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 5, 2026
@mervereis
Copy link
Author

mervereis commented Feb 5, 2026

sorry I sent them wrong pr I changed now and added needs review label.Thanks for your feedback @cjyuan

@cjyuan
Copy link
Contributor

cjyuan commented Feb 5, 2026

The content in the footer is still not quite centered.

image

On a narrow browser window, there is more space on the left than on the right.

If you inspect the element using the Browser Devtool, you may see it clearer.
image

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 5, 2026
@mervereis
Copy link
Author

mervereis commented Feb 5, 2026

@cjyuan I fixed the issue on the footer about styling

@mervereis mervereis added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 5, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 6, 2026

All good now. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mervereis @cjyuan